search

proto-verse / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

+myjob/add missing get() #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
+myjob/add is missing a get() in the not-locked and tagged-for check. Also
unbalanced brackets.

Original issue reported on code.google.com by grey...@gmail.com on 7 Sep 2006 at 9:10

GoogleCodeExporter commented 9 years ago 
Initial changes added to the full and patch installs. Still need verification.

Original comment by grey...@gmail.com on 7 Sep 2006 at 9:11

GoogleCodeExporter commented 9 years ago 
Fixed in revision 10.

Original comment by grey...@gmail.com on 8 Jan 2007 at 5:04

GoogleCodeExporter commented 9 years ago 
There are still further issues with this code. Namely its unclear why it seems 
like
the lock and tagged_for are lumped together? Was the intent that if a job if 
tagged
for a player, other players can't tag the job? If so that behaviour differs 
from the
default tagging and is thus confusing. In the end I'm going to pull out the
tagged_for check and keep the +myjob/add behaviour the same as the +job/add 
behaviour.

Original comment by grey...@gmail.com on 9 Jan 2007 at 5:02

GoogleCodeExporter commented 9 years ago 
Patch tested and working, with above changes in revision 21.

Original comment by grey...@gmail.com on 9 Jan 2007 at 5:07

GoogleCodeExporter commented 9 years ago 
Verified fixed in 5.1.

Original comment by grey...@gmail.com on 9 Jan 2007 at 5:50