proto-verse / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

Rhost Compatibility #95

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Installed 6.0 branch as of r294 on stock Rhost install.  Following issues
need fixing:

1. The wiz installing must be set SIDEFX in order to use create() to get
VA, VB, VC.  This may be something we note in a README, or we can actually
do a check at the beginning of the install and set it prior to creating the
objects and remove afterward.  I'd prefer the former, as I'm extremely
hesitant to set a flag on a player that affects security (if they abort the
install before it's unset and don't realize it... etc.).

2. Rhost does not accept @nuke and requires @dest.  Unfortunately this
means we have no single MUX/Penn/Rhost cross-platform @destroy command. 
I'll restore &TRIG_DESTROY to the earlier Rhost/MUX compat
"@destroy/instant" version and toss in a switch for Penn to do a double-@nuke.

3. Rhost does not have table(): the four object @descs need a
columns(<list>,18,4) instead.

4. Rhost columns() requires the third argument. FN_COLUMNS needs to be
updated to account for this.

5. Rhost does not support width().  At this time I am unaware of any way to
detect client width.  Need to update FN_WIDTH to pick a reasonable default
(79 or 80), or have someone tell me how to get width().

6. Rhost does not support the align() function which is used in the Penn
version of the pie charts, and the MUX pie chart version doesn't work on
Rhost.  Modification of the pie chart code is needed to mix and match the
parts that do work.

7. Rhost uses @reboot rather than @restart or @shutdown/reboot.  

Original issue reported on code.google.com by widdis@gmail.com on 5 Feb 2010 at 7:09

GoogleCodeExporter commented 9 years ago
As of r269, I've addressed #2, 3, 4, 5, and 7 and tested new code on 
Penn/Rhost/MUX.

#1 Is probably a documentation thing.  README.RHOST, anyone?

#6 looks like I can use printf() as a substitute for align().

Original comment by widdis@gmail.com on 5 Feb 2010 at 6:56

GoogleCodeExporter commented 9 years ago
I painstakingly went through the pie chart code and made it work across
MUX/Rhost/Penn.  I removed the "elegant" penn Solution with align and 
regeditall, and
just tweaked the ansi code from the old MUX version.  Rhost couldn't handle the 
\
delimiter so switched to | (and updated map appropriately).

As of r270, +jobs is fully implemented in Rhost.  Now, back to testing.

(Still need to document SIDEFX per #1.)

Original comment by widdis@gmail.com on 6 Feb 2010 at 8:32

GoogleCodeExporter commented 9 years ago
8. Evaluating search() in Rhost doesn't work with the square brackets.

9. Setting attributes by escaping % as \% doesn't work.  Use lit().

10. Rhost lcon() returns #-1 for an empty object.  This could crop up when 
there are
no jobs or no jgroups.  Will need to use t() to test for emptiness.

11. Rhost mail syntax:  mail <player list>=<subject>//<body>

Original comment by widdis@gmail.com on 8 Feb 2010 at 2:07

GoogleCodeExporter commented 9 years ago
8-11 fixed in r273. Still working on a full test... 

Original comment by widdis@gmail.com on 8 Feb 2010 at 3:26

GoogleCodeExporter commented 9 years ago
Full test complete. Final bugs fixed in r274.

One remaining issue is that elist() behaves oddly with the default Rhost setup, 
so
FN_ITEMIZE doesn't behave as it should.  This is a Rhost issue, not jobs... we 
could
remove the elist() option and use FN_PRETTY, or just rely on users to config
correctly (or Rhost to fix the issue).

Original comment by widdis@gmail.com on 8 Feb 2010 at 7:51

GoogleCodeExporter commented 9 years ago
The elist() issue in the latest stable release has been fixed in newer 
released. 
Going to close this.

Original comment by widdis@gmail.com on 8 Feb 2010 at 7:59