FIX cell formulas not working for writing Workbook

protobi / js-xlsx

XLSX / XLSM / XLSB (Excel 2007+ Spreadsheet) / ODS parser and writer

http://oss.sheetjs.com/js-xlsx

Other

826 stars 416 forks source link

FIX cell formulas not working for writing Workbook #11

Open Ahmed--Mohsen opened 8 years ago

Ahmed--Mohsen commented 8 years ago

There is an issue when trying to write cell with f attribute (formula) that the cell got ignored and not written in the output file as expected

pietersv commented 8 years ago

@Ahmed--Mohsen Thanks for reporting. For diagnostic, do you know if it works correctly with the original SheetJS/js-xlsx?

Ahmed--Mohsen commented 8 years ago

@pietersv No its not working on SheetJS/js-xlsx

This was an old issue that was reported on the main repo: https://github.com/SheetJS/js-xlsx/issues/152
This fix is heavily inspired by this commit: https://github.com/mcsf/js-xlsx/commit/d43964564d2d455271a9348f904fe2c34e5b1a59
My usage depends heavily on your excellent work for styling so I need to fix it here first to be able to use bower with it

pietersv commented 8 years ago

@Ahmed--Mohsen Aha, that's likely a deeper issue with the main branch outside the scope of styling. Can accept a pull request to this branch if you figure this out.

Alternately, if this is for a professional project and you just need it done in the next couple days, can do this under a statement of work. I estimate this at four to six hours. Results would be included in the this public project with unit tests, accessible via bower and npm. Contact me directly if useful.

evk0 commented 7 years ago

UP. Issue was fixed in main branch: https://github.com/SheetJS/js-xlsx/commit/5a3774e36ec9d93a0d3aaf356b29697821e50f72