search

protobi / js-xlsx

XLSX / XLSM / XLSB (Excel 2007+ Spreadsheet) / ODS parser and writer
http://oss.sheetjs.com/js-xlsx
Other
826 stars 416 forks source link

Updating default fill styles - previous values were incorrect #3

Closed bendalton closed 9 years ago

bendalton commented 9 years ago

Previous values resulted in a styles.xml with:

  <fills count="2">
    <fill>
      <patternFill patternType="solid">
        <bgColor/>
      </patternFill>
    </fill>
    <fill>
      <patternFill patternType="solid">
        <bgColor/>
      </patternFill>
    </fill>
  </fills>

instead of the expected:

 <fills count="2">
    <fill>
      <patternFill patternType="none"/>
    </fill>
    <fill>
      <patternFill patternType="gray125"/>
    </fill>
  </fills>
bendalton commented 9 years ago

This caused some nasty issues when attempting to render the xlsx file outside of Excel. For example: http://note.io/1BKBfIQ

pietersv commented 9 years ago

Thanks!

bendalton commented 9 years ago

Did you end up merging this in?

protobi commented 9 years ago

Done. Turns out there was a really arcane issue with xls files related to gray125 yelding an out of memory error, so tweaked it a tiny bit further. This gray125 issue maybe even date back to the first release of Office for Mac, as that pattern totally reminds me of the early Macintosh days.

[image: Inline image 1]

On Thu, Jun 4, 2015 at 10:35 AM, Ben Dalton notifications@github.com wrote:

Did you end up merging this in?

— Reply to this email directly or view it on GitHub https://github.com/protobi/js-xlsx/pull/3#issuecomment-108916737.

Pieter Sheth-Voss PhD

protobi e: pieter@protobi.com m: 617.645.4524

bendalton commented 9 years ago

Wow. Thanks! On Thu, Jun 4, 2015 at 12:09 PM Pieter Sheth-Voss notifications@github.com wrote:

Done. Turns out there was a really arcane issue with xls files related to gray125 yelding an out of memory error, so tweaked it a tiny bit further. This gray125 issue maybe even date back to the first release of Office for Mac, as that pattern totally reminds me of the early Macintosh days.

[image: Inline image 1]

On Thu, Jun 4, 2015 at 10:35 AM, Ben Dalton notifications@github.com wrote:

Did you end up merging this in?

— Reply to this email directly or view it on GitHub https://github.com/protobi/js-xlsx/pull/3#issuecomment-108916737.

Pieter Sheth-Voss PhD

protobi e: pieter@protobi.com m: 617.645.4524

— Reply to this email directly or view it on GitHub https://github.com/protobi/js-xlsx/pull/3#issuecomment-108951614.