search

protobi / js-xlsx

XLSX / XLSM / XLSB (Excel 2007+ Spreadsheet) / ODS parser and writer
http://oss.sheetjs.com/js-xlsx
Other
833 stars 416 forks source link

Fix SST parsing when SST XML has a tag prefix #47

Open mbarzda opened 8 years ago

mbarzda commented 8 years ago

XLSX documents written by DocumentFormat.OpenXml.dll (at least sometimes) contain a tag prefix "x" in the sharedStrings.xml file. This is a fix to the regular expressions that parse this file to handle the prefix if it is present. https://github.com/SheetJS/js-xlsx/pull/271

protobi commented 8 years ago

Thanks! I see you've made changes to the bits directly which is great. I also see that you've run the test suite, also great.

There's a commit note that certain tests are excluded. Being unable to running the complete test suite on Node 4+ has been the time bottleneck I've been meaning to get to to. Identifying/removing tests specific to node 4 might a good pragmatic alternative to porting over the XLS and XLSB formats. What version of Node do the tests run on?

Pieter

On Thu, Oct 6, 2016 at 9:57 AM, Martynas Barzda notifications@github.com wrote:

XLSX documents written by DocumentFormat.OpenXml.dll (at least sometimes) contain a tag prefix "x" in the sharedStrings.xml file. This is a fix to the regular expressions that parse this file to handle the prefix if it is

present. SheetJS#271 https://github.com/SheetJS/js-xlsx/pull/271

You can view, comment on, or merge this pull request online at:

https://github.com/protobi/js-xlsx/pull/47 Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/protobi/js-xlsx/pull/47, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRm1a8Oa7W-Et2kfsI42mWvqYDL37nCks5qxP5VgaJpZM4KP-Nw .

mbarzda commented 8 years ago

Hi, general tests (make test) are still failing, but misc tests work with skips. I runned tests on Node v5.10.1