search

protobi / js-xlsx

XLSX / XLSM / XLSB (Excel 2007+ Spreadsheet) / ODS parser and writer
http://oss.sheetjs.com/js-xlsx
Other
817 stars 417 forks source link

Add freezepanes fix styleid #69

Open rwacross opened 7 years ago

rwacross commented 7 years ago

Added code to read out frozen panes from an xlsx and store in !freeze (as opposed to !merge etc.)

Added code to handle a self closing font bracket produced by Google Sheets xlsx exporter. This was causing styleIds to be incorrect.

pietersv commented 7 years ago

@rwacross Thanks! The way the root SheetJS/js-xlsx library is architected, it generates xlsx.js by catenating the files in the bits/*.js directory when running make. Can you make the change to the corresponding files under /bits/?

I'm looking for that section of code, and am wondering if this change applies to this repo (protobi/js-xlsx) or to a different fork (spin-io/js-xlsx)? It looks like the spin-io branch has significant enhancements over this branch.

rwacross commented 7 years ago

Hi @pietersv ,

I wrote the changes mainly to handle freezes in Google sheets data which was required for a side project. I believe the edits to the /bits/ version are in the first commit shown "(fix)" - after I noticed they were only in the concatenated version - under bits/47_styxml.js and bits/67_wsxml.js.

I'm not working on that project anymore, so I can't comment on further edits made afterwards, but the changes cleared up a lot of style mismatching and formatting issues.

Also, to clear that up, code was from this repo, and those were the only changes until I stopped working on it at the beginning of June.