search

protobom / sbom-convert

Example CLI project to demo API architecture and protobom library
Apache License 2.0
13 stars 7 forks source link

suggest local build makefile #8

Closed houdini91 closed 1 year ago

houdini91 commented 1 year ago

HI, @manifestori I trying out your new CLI. I know you designed this great DevContainer but i personally find it a bit to much for me basically wanting to build the binary locally with out all the IDE setup. Added a simply Makefile suggestion to make my life easier.

Any concerns of us having two flow of a build the project (both are based on the same goreleaser) ? (maybe we can unify the devContainer to call the makefile or something)

Anyway hope this can simplify the flow others as well.

manifestori commented 1 year ago

@houdini91 Development Container is just a development environment, all users will benefit from having a Makefile / Taskfile, I agree that we can call some make functions from the devcontainer but this is really minor.

BTW: Take a look at https://taskfile.dev/ I wanted to integrate that instead of Makefile, but Make is good for now, I'll submit a PR for Taskfile once Ill get to it.

jspeed-meyers commented 1 year ago

Any reason not to merge this? I say we merge unless anyone objects :)

houdini91 commented 1 year ago

+1 but I don't count .

manifestori commented 1 year ago

Nice job! Merged.