search

protobuf-net / protobuf-net

Protocol Buffers library for idiomatic .NET
Other
4.69k stars 1.05k forks source link

Dot Net Core build with FEAT_DYNAMIC_REF doesnt compile anymore #838

Open sanktanglia opened 3 years ago

sanktanglia commented 3 years ago

I need to use the dynamic ref features in dot net core, but im unable to get it to build using the current code. Ive had to fix a few other random issues but the big one i cant figure out is at https://github.com/protobuf-net/protobuf-net/blob/main/src/protobuf-net.Core/ProtoWriter.State.WriteMethods.cs#L653 it calls TrySerialize but DynamicStub only has TrySerializeAny and TrySerializeRoot neither of which I can see is supposed to replace it

mgravell commented 3 years ago

Please see https://github.com/protobuf-net/protobuf-net/blob/main/docs/3_0.md#changes-to-existing-features

The v2 branch should build for this