protobuf-ruby / beefcake

A sane Google Protocol Buffers library for Ruby
MIT License
276 stars 46 forks source link

Do not play with mutable data #65

Open nogenhat opened 9 years ago

nogenhat commented 9 years ago

There can be issues, when you force encode original string into binary and then someone else want to use this string.

fl00r commented 9 years ago

I believe the problem is here https://github.com/protobuf-ruby/beefcake/blob/71b06dc47b7284f924323bbbb0941d438eb0eb6e/lib/beefcake/buffer/encode.rb#L107

bkerley commented 9 years ago

Is there a way to write a test for this?

bkerley commented 8 years ago

This is closely related to but distinct from #69 and #70 .

That is all :)