protobufjs / protobuf.js

Protocol Buffers for JavaScript & TypeScript.
Other
9.96k stars 1.42k forks source link

Typegen is broken with latest JSDOC. #1296

Open jquense opened 5 years ago

jquense commented 5 years ago

protobuf.js version: 6.8.8

After running pbts for the first time on a project in a few months, we noticed that without changing anything, the generated output for Enums was broken. In particular enums were converted only a namespace, with no enum in the output types.

I tracked this down to the 3.6.0 JSDOC version. which adds node 12 support. https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md#360-may-2019 IT also seems to have broken the output. The unfortunate thing is this broken without changing anything, and pins us to ndoe 10 until something is fixed. Thanks for the excellent library and your time!

mreiche commented 5 years ago

May be related to: https://github.com/protobufjs/protobuf.js/issues/1307 and https://github.com/protobufjs/protobuf.js/issues/1306