search

protocol / filecoin-mecha-twin

Mechanistic model for the Filecoin Economy
MIT License
15 stars 7 forks source link

Time indexed forecast params #3

Closed kkarrancsu closed 1 year ago

kkarrancsu commented 1 year ago

Updates to power forecasting module to accept vector or scalar inputs.

kkarrancsu commented 1 year ago

Addressed all comments with latest push. I agree that the notebooks are a bit messy - I suggest that we merge in the changes to mechafil/ and then I can open a new issue to clean up notebooks.

kkarrancsu commented 1 year ago

curious to know in power.py what's the extra value of having the if logic in lines 43-47 instead of

qa_onboarded_power_vec = np.ones(forecast_lenght) * qa_onboard_power

which I think should return the same?

You are right, but this made me realize that if len(qa_onboard_power) != forecast_lenght, then there'd be a strange error down the line where vector lengths are mismatched. I addressed this with a new helper function to hopefully make this clearer.