search

protocolbuffers / protobuf-javascript

BSD 3-Clause "New" or "Revised" License
351 stars 67 forks source link

Why there's still 'eval' in the latest version of google-protobuf #177

Closed AntiMoron closed 12 months ago

AntiMoron commented 12 months ago

image

After I cloned the source of of this lib, I cannot find the code in the last screenshot at all.

Is the latest build updated to npm?

image

dibenede commented 12 months ago

Yes, the 3.21.2 release is the latest.

You're pointing at the closure compiler output. That specific code appears to come from the closure library (one of our deps): https://github.com/google/closure-library/blob/b8be837790a4b1e385e56619b4b6fa02c55104b2/closure/goog/base.js#L1091