Update protobuf-javascript to support Protobuf 25.2

protocolbuffers / protobuf-javascript

BSD 3-Clause "New" or "Revised" License

330 stars 66 forks source link

Update protobuf-javascript to support Protobuf 25.2 #196

Closed eric-skydio closed 3 months ago

eric-skydio commented 3 months ago

This PR updates the code in protobuf-javascript to compile against the latest protobuf versions.

This primarily entails:

Using absl:: methods instead of the previous vendored ones in Protobuf
Explicitly using legacy descriptors when important properties are missing
Explicitly deleting constructors rather than relying on the deleted GOOGLE_DISALLOW_EVIL_CONSTRUCTORS

eric-skydio commented 3 months ago

This could be required if you see errors like this after a protobuf upgrade:

In file included from external/protobuf_javascript/generator/protoc-gen-js.cc:33:0:
external/protobuf_javascript/generator/js_generator.h:39:10: fatal error: google/protobuf/stubs/logging.h: No such file or directory
 #include <google/protobuf/stubs/logging.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

eric-skydio commented 3 months ago

It looks like the first version of this failed because I didn't actually update the bzlmod dependency, so CI was building against an old version of protobuf. This didn't come up in my local testing since our repo pulls in newer protobuf through other mechanisms.