protocolbuffers / protobuf

Protocol Buffers - Google's data interchange format
http://protobuf.dev
Other
65.61k stars 15.49k forks source link

CMake build outputs empty line when VERSION_PRERELEASE is not set #17134

Open StefanBruens opened 4 months ago

StefanBruens commented 4 months ago

The following is generated for non-PRERELEASE builds:

--   Protocol Buffers Configuring...
--   
--   23.3.0
--   Configuration script parsing status [
--     Description : Protocol Buffers
--     Version     : 23.3.0 (4.23.3)
--     Contact     : protobuf@googlegroups.com
--   ]
--   Protocol Buffers Configuring done

I think the empty line and the following version are debugging leftovers, and not actually useful. They are also redundant when protobuf_VERBOSE is used.

https://github.com/protocolbuffers/protobuf/blob/2eb4d69ed51c475a77ecd62742ef5064557b531f/CMakeLists.txt#L106-L125

I think the two messages (${protobuf_VERSION_PRERELEASE}, ${protobuf_VERSION}) should be removed, or only be output in case protobuf_VERBOSE is not set:

  if(protobuf_VERBOSE)
    ...
  else()
    message(STATUS "Protobuf: ${protobuf_VERSION} (${protobuf_VERSION_STRING})")
  endif()
github-actions[bot] commented 1 month ago

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago. This issue will be closed and archived after 14 additional days without activity.

StefanBruens commented 1 month ago

Thats not triaging, that is annoying contributors ...