protocolbuffers / protobuf

Protocol Buffers - Google's data interchange format
http://protobuf.dev
Other
65.11k stars 15.43k forks source link

file_mask.proto is missing a go_package #2057

Closed tswast closed 7 years ago

tswast commented 8 years ago

https://github.com/google/protobuf/blob/master/src/google/protobuf/field_mask.proto

This file probably needs

option go_package = "github.com/golang/protobuf/ptypes/fieldmask";

I have filed https://github.com/golang/protobuf/issues/226 to track including it in the Go protobuf package.

tswast commented 8 years ago

I am working on writing conformance tests for Go and this is needed (mostly because Go doesn't do really relative imports and the Go protobuf compiler doesn't support compiling to multiple packages https://github.com/golang/protobuf/issues/39)

anandolee commented 7 years ago

Already fixed by option go_package = "google.golang.org/genproto/protobuf/field_mask;field_mask";