Make txtpbfmt work outside google3

protocolbuffers / txtpbfmt

txtpbfmt parses, edits and formats text proto files in a way that preserves comments.

Apache License 2.0

97 stars 19 forks source link

Make txtpbfmt work outside google3 #36

Closed jschaf closed 2 years ago

jschaf commented 2 years ago

Not sure what the policy is on accepting external changes is, but if you're open to it here's what I had to fix to get this library to work in our repo.

Breaks when imported by the Bazel tool gazelle because:

go-wordwrap is not listed as a dependency in go.mod
fmt_test uses google3 runfiles which don't exist outside Google, causing:

fmt/fmt_test.go:8:2: package google3/base/go/runfiles is not in GOROOT
fix warning about converting from an int to a string

kssilveira commented 2 years ago

I'm also doing a separate internal change to try to fix the "import/copybara — An error happened while migrating the change" error.

kssilveira commented 2 years ago

I think I have fixed the copybara error, could you "make the check run again"?

jschaf commented 2 years ago

Thank you for quick turn around. I've removed fmt_test and it looks like copybara is working.

kssilveira commented 2 years ago

Thanks! This is now going through the internal process that will trigger the merge, I expect it will be merged next week.