search

protofire / AIP-011-Ownable

0 stars 2 forks source link

removed Const class #4

Closed xiwix closed 5 years ago

patitonar commented 5 years ago

@xiwix On the review it was mentioned that isOwner could be improved as:

@Callable
public static boolean isOwner() {
    return owner.equals(Blockchain.getCaller());
}

Despite Blockchain.getCaller() is not returning real address in non-transactions, making the method public @callable could be helpful for another contract to call this method on a transaction

xiwix commented 5 years ago

@xiwix On the review it was mentioned that isOwner could be improved as:

@Callable
public static boolean isOwner() {
    return owner.equals(Blockchain.getCaller());
}

Despite Blockchain.getCaller() is not returning real address in non-transactions, making the method public @callable could be helpful for another contract to call this method on a transaction

I dont see much value in doing this as transactions are not returning response.