Labels on some graphs display time in the format hh'th' rather than hh:mm

protofire / maker-governance-dashboard

MakerDAO Governance Dashboard

https://mkrgov.science

16 stars 3 forks source link

Labels on some graphs display time in the format hh'th' rather than hh:mm #347

Closed LongForWisdom closed 4 years ago

LongForWisdom commented 4 years ago

Note that this happens on multiple graphs (and probably more than I've been able to identify). Please double check all the metrics to make sure that the time is not being displayed in this manner.

LongForWisdom commented 4 years ago

Also note that hh:mm should either use a 24 hour clock, or also display am/pm after. I'd suggest using a 24 hour clock.

LongForWisdom commented 4 years ago

This is a bug not an enhancement. By all means put off fixing until we start work on V3 polish and bugfixing milestones. But yeah, this is just incorrect.