Adding Summary entity - Githubissues

protofire / makerdao-scd-subgraph

MakerDAO Single-Collateral Dai subgraph

https://thegraph.com/explorer/subgraph/protofire/makerdao

GNU Lesser General Public License v3.0

1 stars 2 forks source link

Adding Summary entity #32

Closed nicosampler closed 5 years ago

nicosampler commented 5 years ago

Issue #16

In order to test this, you have to run the branch locally. Then in GraphiQL you can run this query:

{
  cdpEngine(id: "0x0") {
    id
    cdpCount
    openCdpCount
    totalCollateral
    totalDebt
    lastBlock
    lastModifiedDate
  }
}

nicosampler commented 5 years ago

@sistemico changes applied! Thx for the review

nicosampler commented 5 years ago

@sistemico @chm1975 Manu pidio cambiar el nombre de la entidad CDPEngine a CDPSystem.

Esto es lo que el opina:

mkrtools y cdp.makerdao.com usan System para mostrar datos a nivel sistema. Deberiamos seguir esa logica, porque el usuario no entiende que es engine.

Seria correcto cambiarlo? te consulto pq vos sugeriste CDPEngine. Aguardo tu comment asi lo modifico en los 2 proyectos si lo crees necesario