search

protofire / moonbeam-safe-react

Gnosis Safe – The most trusted platform to store digital assets on Ethereum
https://gnosis-safe.io
MIT License
4 stars 1 forks source link

Enable Custom Safe Apps #44

Closed davidsemakula closed 1 year ago

davidsemakula commented 1 year ago

First off, great work on the project :slightly_smiling_face:

Context

I recently participated in the Moonbeam Illuminate Hackathon and built a Safe App for managing assets and interacting with dApps on multiple chains from one Safe account using Hyperlane Interchain Accounts.

It's an interesting project for me and one I'll likely continue to hack on beyond the hackathon but it currently can't be used with Moonbeam as the origin/controller chain because of this issue.

Problem

This fork currently removes/disables the Safe Apps page completely. I think I understand the rationale for the decision since not a lot third party safe apps support moonbeam at the moment. However, this also removes the ability for the user to install custom safe apps.

Request

Enable the Safe Apps page so that the user can at least have the option to install custom apps even if the full safe apps catalogue remains disabled.

Proposal

I'm a fullstack developer and I'm happy to contribute to resolving this issue if there's interest in enabling the feature.

However, I also notice that this fork is based on the legacy Safe web UI which is now deprecated in favor of a newer Safe web UI so I'm curious if there's a plan to move over to that as a base for this project as well.

Lastly, I notice that a few of the first-party Safe apps like Tx Builder and Drain Safe aren't chain specific so it should be relatively easy to make those available so that the app catalogue is a little more useful from the get go and I'm happy to contribute to that effort as well.

esantos089 commented 1 year ago

Hi @davidsemakula,

Firstly, sorry for my delay and thank you for the compliment, we are pushing this project all together with Moonbeam Team!

We are about to release the new Safe UI and the possibility of interacting with Safe Apps + custom Apps by this next week!

davidsemakula commented 1 year ago

Hi @esantos089 No problem, and great work ... looking forward to the update to the new UI. I'll close this issue for now.

esantos089 commented 1 year ago

@davidsemakula ,

The deployment was done! Please, let us know in case of questions or problems!

davidsemakula commented 1 year ago

Hi @esantos089 Awesome, Alberto from Moonbeam let me know a while ago that it was up, so I've already had a chance to try it out and looks great. I'll definitely let you know if I run into any issues 🙂