protofire / omen-exchange

Omen exchange
https://omen.eth.link/
GNU Affero General Public License v3.0
66 stars 77 forks source link

Modify MerkleDistributor to allow guild to withdraw unclaimed OMN #2120

Open hexyls opened 3 years ago

hexyls commented 3 years ago

At the moment the default MerkleDistributor does not allow us to retrieve unclaimed OMN, should add this functionality so OMN does not get stuck in the smart contract forever.

hexyls commented 3 years ago

MerkleDistributor has been updated with a simple withdraw function: https://github.com/hexyls/omen-airdrop/blob/master/contracts/MerkleDistributor.sol#L217

@KadenZipfel can you please checkout this change 👆

I don't think we should specify how long until we can withdraw, we can just lean on a social consensus target of three months and then vote to withdraw when ready.

kadenzipfel commented 3 years ago

MerkleDistributor has been updated with a simple withdraw function: https://github.com/hexyls/omen-airdrop/blob/master/contracts/MerkleDistributor.sol#L217

@KadenZipfel can you please checkout this change 👆

I don't think we should specify how long until we can withdraw, we can just lean on a social consensus target of three months and then vote to withdraw when ready.

Should be function withdraw() public onlyOwner, and I actually think that we should set a minimum time until withdraw since it takes some time for the guild to properly stabilize and decentralize, and until then we probably don't want to have such a powerful function. I've also made a note to make sure this is reviewed in audit

hexyls commented 3 years ago

@KadenZipfel updated: https://github.com/hexyls/omen-airdrop/blob/master/contracts/MerkleDistributor.sol#L219 What do you think about the three month withdraw delay? Too long, too short, just right? 😄

kadenzipfel commented 3 years ago

@KadenZipfel updated: https://github.com/hexyls/omen-airdrop/blob/master/contracts/MerkleDistributor.sol#L219 What do you think about the three month withdraw delay? Too long, too short, just right? 😄

Still need to remove the brackets () on onlyOwner, but I think 90 days is a good amount