protofire / omen-exchange

Omen exchange
https://omen.eth.link/
GNU Affero General Public License v3.0
66 stars 78 forks source link

Liquidity Provider fee doesn't show custom fee in tooltip. #2148

Closed kobellomango closed 3 years ago

kobellomango commented 3 years ago

Describe the bug When a market has a custom LP fee, such as 3%, the tooltip does not show this figure, but instead shows the default LP fee as 2%.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://omen.eth.link/#/0x617df4629b2b11ab775562b69ff20e148fe77fb8/buy
  2. Click on 'Outcome'
  3. Scroll down to 'Fund Market'
  4. Enter amount
  5. Hover tooltip beside 'Fee' to the right.
  6. Witness the tooltip incorrectly stating a 2% LP fee, when it's 3%.

Expected behavior I expected to see "A 3% fee goes to liquidity providers"

Screenshots image

Note: Screenshot taken from market with 4% fee.

Desktop (please complete the following information):