search

protofire / omen-exchange

Omen exchange
https://omen.eth.link/
GNU Affero General Public License v3.0
66 stars 77 forks source link

Feature: Add 2.5% potential fee info when user wants to bond on an ou… #2169

Closed Frankaus closed 3 years ago

Frankaus commented 3 years ago

closes https://github.com/protofire/omen-exchange/issues/2073

Feature: Add 2.5% potential fee info when user wants to bond on an outcome

pimato commented 3 years ago
  1. Maybe to increase the decimal amount to 3 since for the first instance on xDai its not showing most accurate amount..Heres market to test http://localhost:3000/#/0xac4754e37eaef8bd7d72342b1c084a592dbe1ab9/set_outcome Screenshot 2021-08-12 at 16 06 25

can we just not round the potential fee here and just show 0.02 instead of rounded up to 0.03?

  1. This can be made into another issue I just noticed it. But on the table on top right it says bonded and Dai next to it(the markets collateral). When in fact you can only bond with native asset in this case eth. http://localhost:3000/#/0x6f62dbfcaec45973fa5dc25ec958663c4f9a6a00/set_outcom Screenshot 2021-08-12 at 16 08 35

great catch, created a separate issue: https://github.com/protofire/omen-exchange/issues/2192