Fix: Font-size and margin on Settings and broken RPC

protofire / omen-exchange

Omen exchange

https://omen.eth.link/

GNU Affero General Public License v3.0

66 stars 77 forks source link

Fix: Font-size and margin on Settings and broken RPC #2182

Closed Frankaus closed 3 years ago

Frankaus commented 3 years ago

closes https://github.com/protofire/omen-exchange/issues/2082

Changed the font-size to default (14px) in RPC endpoint and removed the margin-left of Settings in broken RPC

pimato commented 3 years ago

It looks like the emergency rpc modal has not the correct font:

compared to the one in the Your Connection Modal:

looks like the buttons are using Arial font instead of Roboto:

pimato commented 3 years ago

@Frankaus you missed out a few others:

Frankaus commented 3 years ago

@Frankaus you missed out a few others:

Seems to happen because it was not specified in the code before and so the browser applies a default font. I will look at all of them now and make sure to specify the font-family Roboto

Frankaus commented 3 years ago

any clue why the dropdown in our normal dropdown is 40px height but the emergency rpc node modal has a dropdown with 42px height?

normal:

emergency dropdown:

because the height was never set on this box. Do you want it to be 40px or 42px?

pimato commented 3 years ago

any clue why the dropdown in our normal dropdown is 40px height but the emergency rpc node modal has a dropdown with 42px height? normal:

emergency dropdown:

because the height was never set on this box. Do you want it to be 40px or 42px?

40px as we have it throughout the application.