Scalar market slider not behaving correctly - Githubissues

protofire / omen-exchange

Omen exchange

https://omen.eth.link/

GNU Affero General Public License v3.0

66 stars 77 forks source link

Scalar market slider not behaving correctly #2184

Closed kadenzipfel closed 3 years ago

kadenzipfel commented 3 years ago

Describe the bug The positioning and returned profit/loss values of slider are not correct, e.g. it says you're in profit if the final outcome is at the point in which the price impact of your order should set it to, when in reality you should start at a small loss due to the fee.

To Reproduce

Go to the buy view on a scalar market, e.g. https://omen.eth.link/#/0x9fab6bc0e60c3fc9c70ea8f2f09bfba80c3e9572/buy and test with different inputs.

Screenshots Slider not in correct spot (should be past halfway)

Desktop (please complete the following information):

OS: macOS Big Sur
Browser: Chrome
Version 92.0.4515.107

kadenzipfel commented 3 years ago

Looks like part of this (the profit/loss estimation) is actually correct, and the other part (the slider position) is already fixed on dxtest.eth.link, so seems like we're all good!