search

protofire / omen-exchange

Omen exchange
https://omen.eth.link/
GNU Affero General Public License v3.0
67 stars 78 forks source link

Liq rewards proposals #2205

Open hexyls opened 3 years ago

hexyls commented 3 years ago

closes https://github.com/protofire/omen-exchange/issues/2044

hexyls commented 3 years ago

@pimato - we can just do an initial styling review for this one, then I can fix up any issues in prep for https://github.com/protofire/omen-exchange/pull/1851 being merged

current version is missing: scalar market styling, any contract interactions

pimato commented 3 years ago

In order to have not stretched components like this we need to give the text box a fixed height of 54px and align the text vertically centered.

currently:

Bildschirmfoto 2021-08-19 um 15 29 35

should:

Bildschirmfoto 2021-08-19 um 15 31 23

for mobile we can remove the height property as we don`t need to take care of equal heights anymore:

Bildschirmfoto 2021-08-19 um 15 38 17
pimato commented 3 years ago

Now that we have our clearly defined text styles, we should start using them: https://github.com/protofire/omen-exchange/pull/2078/files

Mi-Lan commented 3 years ago

@hexyls Hey men I started working on this issue https://github.com/protofire/omen-exchange/issues/2128 for and found that you have similar table like the one in proposal details view...This table... Screenshot 2021-08-27 at 14 09 18 Maybe we can reuse it for your pr and my upcoming one...And adjust it a little? What do you think? Only issue is that I made it responsive based on screen width..