protofire / omen-exchange

Omen exchange
https://omen.eth.link/
GNU Affero General Public License v3.0
66 stars 78 forks source link

Make market search case-insensitive #666

Open pimato opened 4 years ago

pimato commented 4 years ago

I just tried to search a few market and it seems like if something was written capitalized, it can`t be found by a term which is written lower case.

Markets:

Screenshot 2020-05-13 at 20 21 11

Search result:

Screenshot 2020-05-13 at 20 21 24
fvictorio commented 4 years ago

This is a limitation of thegraph: https://github.com/graphprotocol/graph-node/issues/1624

fvictorio commented 4 years ago

This might be improved if the subgraph adds fulltext search support: https://thegraph.com/docs/define-a-subgraph#defining-fulltext-search-fields

kadenzipfel commented 4 years ago

Looks like fulltext search support isn't quite the solution we're looking for. There is, however, this issue https://github.com/graphprotocol/graph-node/issues/1837 that may provide a solution.