protofire / solhint

Solhint is an open-source project to provide a linting utility for Solidity code.
https://protofire.github.io/solhint/
MIT License
1.04k stars 161 forks source link

New possible rules to analyze #568

Open dbale-altoros opened 8 months ago

dbale-altoros commented 8 months ago

boolean_comparison Checks if an expression contains a comparison with a boolean literal, which is unnecessary. (best practices)

division_before_multiplication Checks for division operations before multiplications, which can result in value truncation.

external_call_in_loop Checks if any functions contain any loops which perform calls to external functions. (security)

missing_logs Checks for publicly-accessible functions that make changes to storage variables without emitting logs. (security)

storage_read_in_loop_condition Checks for loops that contain a storage read in their condition, which can increase gas costs for each iteration. (gas)

ScreamingHawk commented 6 months ago

unused_return_value

This is already a compiler warning for low level calls and could be extended for all calls.

dbale-altoros commented 6 months ago

@ScreamingHawk thanks for your input