search

protofire / solhint

Solhint is an open-source project to provide a linting utility for Solidity code.
https://protofire.github.io/solhint/
MIT License
1.04k stars 162 forks source link

Exclude abi.encodeX calls from func-named-parameters #583

Closed 0xCLARITY closed 4 months ago

0xCLARITY commented 6 months ago

Solhint regularly complains about the named-parameters rule when all I'm doing is throwing a bunch of data into abi.encode() or abi.encodePacked().

Rather than annotating every single abi.encodeX() call with a //solhint-disable - I think it makes more sense to exclude abi.encodeX() calls from this rule at the rule implementation.

Tested locally on the contract I'm currently writing and works as expected.

0xCLARITY commented 6 months ago

@dbale-altoros - I pushed up a commit that I think fixes the linting issues of CI, but I'm not sure how to re-trigger the jobs. Any idea?

dbale-altoros commented 6 months ago

@dbale-altoros - I pushed up a commit that I think fixes the linting issues of CI, but I'm not sure how to re-trigger the jobs. Any idea?

I need to do that... already passed all of the CI tests... great job

dbale-altoros commented 4 months ago

@0xCLARITY this week there will be a new release with this addition thanks for the contribution

0xCLARITY commented 4 months ago

@dbale-altoros - any ETA on a new release?

dbale-altoros commented 4 months ago

@0xCLARITY yes sorry I was waiting feedback from this issue https://github.com/protofire/solhint/issues/571 to put both updates together... pretty confident next week will be a new release