Automatically determine :ssl based on connection uri

protojure / lib

A collection of libraries to support Protojure applications at runtime

https://protojure.readthedocs.io

Apache License 2.0

64 stars 14 forks source link

Automatically determine :ssl based on connection uri #133

Open reify-james-vickers opened 2 years ago

reify-james-vickers commented 2 years ago

protojure.grpc.client.providers.http2/connect takes a map that must contain :uri and can optionally contain :ssl with boolean value. It seems possible to automatically know that SSL should be used if the uri starts with https:// which is defining the connection scheme as HTTPS/SSL. Would it be possible to not have to provide :ssl in such cases then?

ghaskins commented 2 years ago

Yes, definitely possible. The ssl field should remain for backwards compat, but we could make it have a default based on the scheme. I would consider a PR that implements this.

reify-james-vickers commented 2 years ago

https://github.com/protojure/lib/pull/136