Open reify-james-vickers opened 2 years ago
Yeah, this has bugged me for a while, too. Just never got around to fixing it. PR welcome.
https://github.com/protojure/lib/pull/137
Found it a bit harder to support something like "something.com" with no scheme because lambdaisland/uri
apparently won't read a host from that, doesn't seem too important anyway.
Currently
protojure.grpc.client.providers.http2/connect
requires a very specific format for:uri
and does not accept some that it perhaps could. The URI's it seems to accept have scheme as well as port number, e.g.http://localhost:8080
. Any piece missing makes the parsing fail, sometimes with a relatively opaque exception. It would be helpful for instance to support formats like:http://some-host
orhttps://some-host
, using the default port numbers for these protocols (i.e.80
forhttp
and443
forhttps
)(NumberFormatException) at java.lang.Integer/parseInt (Integer.java:614): null
some-host.com
or similar URI's that omit the connection protocol; not clear if it's really necessary to have the protocol or if it can default to something likehttps
or correspond to what:ssl
is defined/provided as.