search

protojure / lib

A collection of libraries to support Protojure applications at runtime
https://protojure.readthedocs.io
Apache License 2.0
64 stars 14 forks source link

grpc-client (jetty): Provide `on-close` callback to `connect` #155

Closed sundbry closed 1 year ago

sundbry commented 1 year ago

Allow clients to provide an on-close callback, which will be triggeredhen the HTTP2Session closes. This allows clients to react gracefully to server-side connections closing.

ghaskins commented 1 year ago

Thanks @sundbry. PR looks good to me.

ghaskins commented 1 year ago

@sundbry You need to add a DCO statement to your commit message, such as 

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
sundbry commented 1 year ago

Hi @ghaskins, after some more testing, this is ready to go!

sundbry commented 1 year ago

@ghaskins I fixed the commit signature issue here that was blocking merge.

ghaskins commented 1 year ago

@sundbry https://github.com/protojure/lib/releases/tag/v2.8.1

Thank you!