search

protoloft / klipper_z_calibration

Klipper plugin for self-calibrating z-offset
GNU General Public License v3.0
1.06k stars 152 forks source link

Attach & Detach Probe Documentation Macro has simple spelling mistake #62

Closed evader closed 2 years ago

evader commented 2 years ago

Love your solution. Simple mistake under documentation for Attach & Detach Probe Macro on your main page. You have CG28 instead of G28. Hope this helps and many many thanks for your tremendous work.

Screen Shot 2022-05-10 at 9 18 58 pm

Hoping the macro should be like the following.

[gcode_macro CALIBRATE_Z] rename_existing: BASE_CALIBRATE_Z gcode: {% set bed_position = params.BED_POSITION|default('None') %} G28 M117 Z-Calibration.. ATTACH_PROBE # a macro for fetching the probe first {% if bed_position != 'None' %} BASE_CALIBRATE_Z BED_POSITION={bed_position} {% else %} BASE_CALIBRATE_Z {% endif %} DETACH_PROBE # and parking it afterwards (or DOCK_PROBE in klicky macros) M117

TravisWilder commented 2 years ago

why G28 and not G28 Z

CG28 might be custom macro Conditional Homing


[gcode_macro CG28]
description: Helper: Conditional homing
gcode:
  {% if "xyz" not in printer.toolhead.homed_axes %} G28 {% endif %}
jangrewe commented 2 years ago

It is: https://docs.vorondesign.com/community/macros/macros/120decibell.html

TitusLabs commented 2 years ago

Yes, that is the conditional homing macro. But sorry, that is not clear in this context... I will change that :+1: