search

protoloft / klipper_z_calibration

Klipper plugin for self-calibrating z-offset
GNU General Public License v3.0
1.05k stars 151 forks source link

If the offset is too large, dock the probe before raising an error condition #63

Closed top-gun closed 2 years ago

top-gun commented 2 years ago

When the calculated offset is higher than the threshold, the script raises an error and aborts, leaving the probe attached to the toolhead. This is not a safe condition, and on printers like the V2.4, it is not easily recognized by the operator as the probe is under and behind the toolhead.

The change stows the probe before raising the error, leaving the printer in a safe condition.

TitusLabs commented 2 years ago

My printer docks the probe after homing if attached. But I have to admit that this depends on your macros. Nice improvement :+1:

top-gun commented 2 years ago

Yes, this is totally dependent on the probe macros you use. I guess you run Euclid? For me, it's Klicky. If the computed offset is too high, the error condition stops g-code execution, and the printer simply stops doing anything. All axis are defined, so when I see the error, I can do anything with the machine. My first reflex was to run the toolhead down to check the clearance - and since Stealthburner conceals the probe, I didn't notice it was still attached. Well, it's mostly printed plastic, but Mr Omron needs a new offset after that. And I guess it's not for the better. Thanks for merging :)