search

protoloft / klipper_z_calibration

Klipper plugin for self-calibrating z-offset
GNU General Public License v3.0
1.06k stars 152 forks source link

offset_margins Not effective #93

Closed ptsa closed 1 year ago

ptsa commented 1 year ago

Offset is greater than allowed: offset=1.210 > max_deviation=1.000

in klicky-z-calibration.cfg i set offset_margins: -3.0,3.0 But the prompt still exceeds the range

educatedCaveman commented 1 year ago

I am having a similar issue. I found that if i added the max_deviation line back, it worked. But I think the code should either be fixed, or the documentation updated.

TitusLabs commented 1 year ago

For backward compatibility, the max_deviation is used over the offset_margins if it is used in your configuration. The "offset is greater as allowed" is the error message of the max_deviation configuration. So, please check if you still have this in your configuration...

May be I should add a check to not have both defined in the configuration :thinking:

TitusLabs commented 1 year ago

Sorry, you were right. There was a bug using always the default of max_deviation. This is fixed now in 1.0.1 :+1:

TitusLabs commented 1 year ago

Is fixed with 1.0.1. If there are still issues, please open a new ticket..