search

protomaps / OSMExpress

Fast database file format for OpenStreetMap
BSD 2-Clause "Simplified" License
229 stars 19 forks source link

Fix examples #29

Closed nside closed 3 years ago

nside commented 3 years ago

examples didn't build out of the box also cd examples ; cmake . didn't work on my system. guessing it was linking from system versions

nside commented 3 years ago

followed same instructions as your developer guide, passing it via cmake -DOPENSSL_ROOT_DIR=/opt/homebrew/opt/openssl@1.1/ .

bdon commented 3 years ago

@nside I am actually thinking maybe we should get rid of the CMakeLists in the examples directory and add it as another target to the root CMakeLists, like the test suite. This would make building the examples faster/easier and reduce duplication of the build config, what do you think?

bdon commented 3 years ago

Hmm, on the other hand, having an example CMakeLists for users who want to work out of the main tree is also useful. Let me think about this some more

nside commented 3 years ago

I think examples that can be built independently/externally are more valuable

bdon commented 3 years ago

Thank you!