search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Fix minzoom keys in base_layers #128

Closed bdon closed 1 year ago

bdon commented 1 year ago

@nvkelso it turns out having the wrong key min_zoom instead of minzoom is not only ineffective, it also silently breaks smooth style diffing! Weird. (TODO: figure out a better way to catch this with TypeScript)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nvkelso commented 1 year ago

Ah, this quirk of MapLibre (inherited from Mapbox) styling always gets me. Thanks for the fix!

bdon commented 1 year ago

https://github.com/protomaps/basemaps/pull/130 added type safety to catch this ;)