search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Bus stops bridges #180

Closed bdon closed 10 months ago

bdon commented 10 months ago

Fixes display of bridges shown in #67

Assigns correct pmap:kind to bus stops in #163

@wipfli

Screenshot 2023-11-11 at 08 36 21 Screenshot 2023-11-11 at 08 36 16
sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

wipfli commented 10 months ago

Looks much better :)

wipfli commented 10 months ago

Bridge polygons don't seem to work here:

https://maps.protomaps.com/#map=18.46/47.3601392/8.5233257&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231112.pmtiles

wipfli commented 10 months ago

Or here: https://maps.protomaps.com/#map=16.59/47.377647/8.542377&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231112.pmtiles

bdon commented 10 months ago

https://www.openstreetmap.org/way/537126673 https://www.openstreetmap.org/way/300869313

bdon commented 10 months ago

@wipfli do you think those two above need area=yes tags? they are closed ways with man_made=bridge but that is ambiguous whether it is a circular bridge linear feature or a polygon.

wipfli commented 10 months ago

Is there a way to find out how OSM Carto renders bridge polygons? I think we should use the same logic since Carto has probably the largest impact on how people map...

bdon commented 9 months ago

@wipfli I think it's related to the osm2pgsql Lua tag transform in https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.lua