search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

don't require man_made=bridge outlines have area=yes [#180] #182

Closed bdon closed 9 months ago

bdon commented 10 months ago

See #180

Refer to https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dbridge :

The tag man_made=bridge is used to tag a bridge defined by the outline of the bridge.

@wipfli @nvkelso

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

wipfli commented 10 months ago

Looks good to me

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

bdon commented 9 months ago

@nvkelso visual test output comparing tileset builds:

Screenshot 2024-01-03 at 16 31 49

https://maps.protomaps.com/visualtests/?leftTiles=https%3A%2F%2Fbuild.protomaps.com%2F20240101.pmtiles&name=zurich-bridges

nvkelso commented 9 months ago

Great bug fix!