protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Missing boundaries in various places `pmap:min_admin_level 4` #189

Closed makella closed 9 months ago

makella commented 9 months ago

Location kenya: https://maps.protomaps.com/#map=6.29/0.017/37.603&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231225.pmtiles

columbia: https://maps.protomaps.com/#map=7/4.518/-71.805&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231225.pmtiles

brazil: https://maps.protomaps.com/#map=6.83/-15.131/-46.307&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231225.pmtiles

assuming this is happening in other places as well

Screenshots when zooming in, the boundaries become disjointed as large parts disappear for example here in brazil you see them at z5 and then they disappear if not totally partially

Screen Shot 2023-12-08 at 6 25 40 PM Screen Shot 2023-12-08 at 6 25 53 PM

Required information

bdon commented 9 months ago

@nvkelso for Kenya, the NE release we're using seems to have the pre-2010 provinces of Kenya instead of post-2010 counties

bdon commented 9 months ago

@nvkelso fundamental issue here is that Brazil, Colombia and Kenya use admin_level=3 and admin_level=5 in OSM

Tilezen boundaries don't specify where 3 and 5 should go. We should focus our tileset on display needs and not an arbitrary database - easiest fix is to simply allow 3 and 5 for pmap:min_admin_level

bdon commented 9 months ago

This should be resolved in tiles 3.1.0:

https://maps.protomaps.com/#tiles=https://build.protomaps.com/20240106.pmtiles&map=5.81/-0.255/35.544&theme=light&renderer=maplibregl visual tests: https://maps.protomaps.com/visualtests/?leftTiles=https://build.protomaps.com/20240105.pmtiles&rightTiles=https://build.protomaps.com/20240106.pmtiles