protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Rome vs Vatican State #210

Open wipfli opened 8 months ago

wipfli commented 8 months ago

Location

https://maps.protomaps.com/#map=4.85/42/12.23&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20240120.pmtiles

Screenshots

Screenshot_20240120-224622

Problem

The label of Rome, Italy's capital, gets collided away by the label of Vatican State. I think ot is because country labels always show before city labels. But Vatican should be rather treated as a quarter of Rome. So when zooming in I expect to see Rome and once I see the city outlines I expect to see Vatican too.

bdon commented 8 months ago

@nvkelso thoughts on how to resolve this without hardcoding an exception, based on NE data?

wipfli commented 8 months ago

General question: Are hardcoded exceptions actually that bad of an idea?

nvkelso commented 8 months ago

Let's look in the style? major cities should be preferred over minor countries and minor cities. The min_zoom should already be setup for that in the data, but MapLibre's layer based label collisions sometimes necessitates splitting the rendering into different draw layers?

lymperis-e commented 7 months ago

This is a common problem in almost every Mapbox-GL derived style (screenshot from Maptiler below). Only Mapbox themselves seem to get it right. image

wipfli commented 7 months ago

Are osm identifiers stable enough to use them as ids in an exceptions list? I think for stuff like this there is no other way than making exception lists...