protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Closes #204 and adds POIs for landuse=village_green, laduse=allotment… #212

Closed lenalebt closed 8 months ago

lenalebt commented 8 months ago

…s, leisure=playground

lenalebt commented 8 months ago

Will fix the issues monday or tuesday, won't find time beforehand

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bdon commented 8 months ago

@lenalebt thanks for adding these - can you suggest a representative area of the world so I can try out the PR on it?

The nature of tileset changes is that they will affect the visual output. One of the things I'm working on is a test suite that lets us regression compare visually any two states in the past. Example of a test for bridges: https://maps.protomaps.com/visualtests/?tag=bridge

Ideally a visual test example for this would have one or more playgrounds and village greens / allotments

bdon commented 8 months ago

(Nevermind, I see your link for https://www.openstreetmap.org/#map=18/51.50497/7.31888 , perfect example!)

bdon commented 8 months ago

Merging for now, will follow up with style changes later, thanks!

bdon commented 8 months ago

(visual diff) Screenshot 2024-02-03 at 00 50 07