Buildings with 'railway'-tag also show a railway outline

[pietervdvn]

Location

This building has building=commercial and railway=signal_box. It is included in both railway- and buildings-layer and renders as such:

This is more pronounced in my Sunny-rendering:

Original report: https://github.com/pietervdvn/MapComplete/issues/1953

Required information Browser(s): Chrome 124.0.6367.202, 124.0.6367.208, librewolf (Firefox) OS: Windows 10, Ubuntu

• Renderer version: MapLibre GL JS 4.1.1
• Tileset version and source: protomaps hosted

[nvkelso]

I suspect this feature appearing in both the Buildings layer correctly and the Transit layer incorrectly is caused by allowing fallback passthru railway=* values in the Transit layer instead of using an explicate allowlist (or adding a blocklist):

• https://github.com/protomaps/basemaps/blob/main/tiles/src/main/java/com/protomaps/basemap/layers/Transit.java#L55-L66

Do you want to submit a PR with a fix?

[bdon]

Note for later: it's possible for building=yes and railway=platform : https://www.openstreetmap.org/way/166152585

tilezen visualizes platforms as polygons in the transit layer https://tilezen.readthedocs.io/en/latest/layers/#transit

[pietervdvn]

Thanks for adding a testcase! I was AFK for a few days.

[bdon]

@pietervdvn thanks for the PR, 3.5.2 will run as today's daily build http://maps.protomaps.com/builds/ and then I'll update the API afterwards.

[bdon]

The hosted API has been updated, but it may take a bit for cached tiles to fall out.