protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

Label of New York is blinking #256

Open wipfli opened 3 months ago

wipfli commented 3 months ago

The label of New York City is blinking during zoom.

wipfli commented 3 months ago

Probably this is due to collisions between the places_locality layer and the places_region layer.

bdon commented 3 months ago

I noticed this is happening because we have NE localities conflicting with OSM ones.

We should take geometries only from OSM and augment them with NE properties / minzoom information.

wipfli commented 3 months ago

The Delhi city label also gets collided away by a state label:

map=8.77/28.5699/77.0001

image

nvkelso commented 3 months ago

I wonder about styling all the labels in the places data layer in a single style layer, sorted my the pmap:min_zoom. Then the collisions would be deterministic (if a low-zoom locality is present and labeled before the region, it should win in a collision in later zooms with region, not just other locality features). This would require more complicated nested styling logic, but worth prototyping?

wipfli commented 3 months ago

Interesting idea I think. Another option could be to disable certain state and country labels (e g.: Delhi, Vatican).

bdon commented 1 month ago

Given the situation in #286 I think tile ordering isn't good enough, so we should do this in the style:

I wonder about styling all the labels in the places data layer in a single style layer, sorted my the pmap:min_zoom