protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
378 stars 49 forks source link

link roads missing from a generated map #53

Closed andrey-abstracted closed 1 year ago

andrey-abstracted commented 1 year ago

motorway_links and primary_links are present on OSM maps but missing when a freshly generated map is viewed using PMTiles viewer.

In protomaps-basemap-opensource-20230408.pmtiles primary_links are present but motorway_links are not.

The screenshots are from the freshly generated map viewed using PMTiles viewer.

https://www.openstreetmap.org/way/454442266#map=18/-38.08778/145.32274

Screenshot 2023-07-06 at 12 31 38 pm Screenshot 2023-07-06 at 12 31 24 pm

https://www.openstreetmap.org/way/454442266#map=15/-37.6831/144.9850

Screenshot 2023-07-06 at 12 20 49 pm Screenshot 2023-07-06 at 12 32 11 pm
bdon commented 1 year ago

Thanks, I can verify that this is an issue in specific cases where links consist of multiple ways, working on a fix.

bdon commented 1 year ago

PR https://github.com/protomaps/basemaps/pull/57 is progress towards improving this, but the logic in LinkSimplify needs to change to handle more complex cases like the 2nd.

andrey-abstracted commented 1 year ago

Great, thank you. On a slightly irrelevant note - would it be possible to change the zoom range for motorways from 12-15 to 11-15. That feature is quite a significant visual landmark and is still visible at lower zoom levels.

bdon commented 1 year ago

@andrey-abstracted a major rework of both the display style and base tileset is coming soon; The best option for right now though, and in the future, is to generate your own tileset while modifying the configuration to your needs. This will likely require a small modification to both Java code and JSON styles.

Our goal is to make this kind of adjustment easy via configuration changes and/or style parameters, but that is a medium to long-term project.

andrey-abstracted commented 1 year ago

@bdon yes, absolutely, I've been doing that. In this particular case it felt like a better user experience but that is of course quite subjective.

nvkelso commented 1 year ago

I think this one can be closed as complete (link simplify bug).