search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

pedestrian features in tileset not visualized in style #67

Closed andrey-abstracted closed 10 months ago

andrey-abstracted commented 1 year ago

Sorry to bother again guys, this is just something that might benefit others.

The landuse_pedestrian needs the following added in the layout, currently it only checks for a "footway". Also needs to be moved below the "water" in the layout so that footbridges would stay afloat.

        [
            "==",
            "highway",
            "pedestrian"
        ],
        [
            "==",
           "pmap:kind",
           "pedestrian"
        ]
bdon commented 1 year ago

Thanks. there is currently a mismatch between the default style and tileset where not 100% of features are visualized. We are working on the project infrastructure to make change control more reliable in the future so there are lots of issues like this we will gradually get to. Please consolidate any other issues in this issue instead of opening a new one.

bdon commented 1 year ago

@andrey-abstracted for examples like this can you please also provide one of a screenshot, a zoom/lat/long, or both?

andrey-abstracted commented 1 year ago

@bdon apologies, this is certainly not how I intended to name this ticket.

Everything related to "rail" needs the following added as currently we end up with railway drawn on top of transit_pier

"filter": [ "any", [ "==", "pmap:kind", "railway" ] ],

andrey-abstracted commented 1 year ago

The location for a footbridge is -33.87055828705787, 151.2008064875631. There are some piers and foot walks around. Additionally for the id roads_other "all", [ "==", "pmap:level", 0 ], [ "==", "pmap:kind", "other" ] needs to be replace with pmap:kind = path as footwalks like on the screenshot do not appear on a recently created map

Screenshot 2023-07-19 at 4 11 26 pm

bdon commented 10 months ago

Fixed in style 2.0.0-alpha.4:

https://maps.protomaps.com/#map=17/-33.87182/151.20208&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231110.pmtiles&npm_version=2.0.0-alpha.4

bdon commented 10 months ago

Everything related to "rail" needs the following added as currently we end up with railway drawn on top of transit_pier

I don't think this is true 100% of the case, it should depend on layer similar to highways? It would help to find a couple of examples.