search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

fix null pointer exceptions #77

Closed bdon closed 1 year ago

bdon commented 1 year ago

@nvkelso we should avoid nulls by using the version of the function with a default.

github-actions[bot] commented 1 year ago

Comparison: https://protomaps.github.io/basemaps/ci/?left=2396d922f90270ce8c47dd166a727461a3243792&right=77

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

bdon commented 1 year ago

@nvkelso setZoomRange always needs to be called with minZoom <= maxZoom; otherwise it will throw an assertion error. These assertions are disabled in the prod JAR, but our unit+integration tests should catch them now.