search

protomaps / basemaps

Basemap PMTiles generation and cartographic styles for OpenStreetMap data and more
https://maps.protomaps.com/
Other
347 stars 44 forks source link

layers attr on roads is integer [#72] #85

Closed bdon closed 1 year ago

bdon commented 1 year ago

@nvkelso

This also starts fleshing out unit tests on layers

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 1 year ago

Comparison: https://protomaps.github.io/basemaps/ci/?left=848d94e70b15f6ba3ff7ffd05a42e47bac6d15b1&right=85

andrey-abstracted commented 1 year ago

On a similar note the layers attribute on Buildings and Transit is a string. It would help with filtering out underground structures if it was an integer

bdon commented 1 year ago

Fixed by https://github.com/protomaps/basemaps/pull/100