search

protomaps / go-pmtiles

Single-file executable tool for working with PMTiles archives
https://docs.protomaps.com/pmtiles/cli
BSD 3-Clause "New" or "Revised" License
377 stars 51 forks source link

Add `pmtiles` to homebrew for easy installation - needs more GitHub stars and watchers #39

Closed yuletide closed 1 year ago

yuletide commented 1 year ago

Makes it much easier to keep things up to date

https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request https://docs.brew.sh/Formula-Cookbook Here's the tippecanoe formula: https://github.com/Homebrew/homebrew-core/blob/master/Formula/tippecanoe.rb

Since this is open source it should be acceptable in homebrew-core: https://docs.brew.sh/Acceptable-Formulae

edit: looks like there's even a tool for this: https://jkawamoto.github.io/fgo/ and goreleaser also can generate a formula: https://goreleaser.com/customization/homebrew/

kevinschaul commented 1 year ago

This formula seems to be working, but anyone have edits before I open a PR to homebrew? https://github.com/kevinschaul/homebrew-core/blob/master/Formula/pmtiles.rb

bdon commented 1 year ago

@kevinschaul thanks for opening this PR in Homebrew! FYI I'm tentatively thinking about going back to the 1.x versioning (without any SemVer guarantee) because of problems introduced related to go modules via 2.x : do you think you could change the PR to point to the 1.7.0 release?

kevinschaul commented 1 year ago

@bdon No problem, I just switched it to the 1.7.0 release.

Unfortunately the formula is failing a brew test for not being popular enough:

* GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

But in the meantime, pmtiles can be installed with: brew install kevinschaul/homebrew-core/pmtiles

bdon commented 1 year ago

@kevinschaul great! so a note for anyone observing this GitHub issue, star or watch the repo so we can get it past the threshold!

bdon commented 1 year ago

@kevinschaul with >80 stars now we should pass this test:

https://github.com/Homebrew/brew/blob/fbbcb9700c6a6ee71d9bd66f80c59d21265ffc8c/Library/Homebrew/utils/shared_audits.rb#L98

kevinschaul commented 1 year ago

Nice! Just submitted the PR: https://github.com/Homebrew/homebrew-core/pull/123227

kevinschaul commented 1 year ago

... and it should be merged!

brew install pmtiles should be working now.

bdon commented 1 year ago

Great! I guess we'll need to update Homebrew manually each time we release, but we'll deal with that when we get there.

yuletide commented 1 year ago

Works for me! This is great