[feature] Let the ->addFilter('-threads', '1') rule overrule the "hardwired" threads setting

protonemedia / laravel-ffmpeg

This package provides an integration with FFmpeg for Laravel. Laravel's Filesystem handles the storage of the files.

https://protone.media/en/blog/how-to-use-ffmpeg-in-your-laravel-projects

MIT License

1.66k stars 194 forks source link

[feature] Let the ->addFilter('-threads', '1') rule overrule the "hardwired" threads setting #330

Closed ibrainventures closed 2 years ago

ibrainventures commented 3 years ago

No Breaking change because of the default Rules.

We need to control the used threads per Conversion. Actually it is default ruled per config / default fallback inside Serviceprovider.

So my ->addFilter('-threads', '1') is added inside the ffmpeg flow before this setting and takes no effect. By this rule and config Option i can switch out this default rules and my added Filter is respected.

pascalbaljet commented 2 years ago

Thanks @ibrainventures! I did a small refactor so you don't need the extra configuration key. Now you can just set the ffmpeg.threads key to false. I've tagged v7.7.3 with this PR :)